search

KnpLabs / DoctrineBehaviors

Doctrine2 behavior traits that help handling Blameable, Loggable, Sluggable, SoftDeletable, Uuidable, Timestampable, Translatable, Tree behavior
http://knplabs.com
MIT License
911 stars 286 forks source link

Update Subscribers with #[AsDoctrineListener] #742

Open DennisdeBest opened 8 months ago

DennisdeBest commented 8 months ago

To remove the deprecation from implementing the EventSubscriberInterface this PR is to use the #[AsDoctrineListener] attribute instead.

To do so I set the doctrine/doctrine-bundle to ^2.7.2.

Running the cs-fixer, phpstan and rector showed a couple of errors so I updated Rector and implemented some of the changes that those tools required.

There were errors in the github workflows so I updated the versions of the actions accordingly.

If there is more to update let me know I would be happy to help.

Looking at the current PRs this seems to be a combination of

https://github.com/KnpLabs/DoctrineBehaviors/pull/739

https://github.com/KnpLabs/DoctrineBehaviors/pull/741

https://github.com/KnpLabs/DoctrineBehaviors/pull/738

https://github.com/KnpLabs/DoctrineBehaviors/pull/736

DennisdeBest commented 4 months ago

I updated the tests some more and added support for Symfony 7. I dropped support for Symfony5 and PHP 8.0

This kind of takes the PR #750 into account aswell.

jgrygierek commented 3 months ago

When it will be released?

Enz000 commented 2 months ago

Hello 👋

Any updates about this PR? 😀

DennisdeBest commented 2 months ago

Hello 👋

Any updates about this PR? 😀

Nothing so far 😕I use my fork on multiple projects waiting for it to get merged

jzecca commented 2 months ago

Thanks a lot for the PR! Would be great to have this released.

jgrygierek commented 2 months ago

I really don't understand... What is the problem with releasing this one very important feature? It is just a few minutes...

virtualize commented 2 months ago

@jgrygierek The problem is, that this library does not seem to have any active maintainers for quite some time. See #711

DennisdeBest commented 2 months ago

@alexpozzi

Thanks for the reply.

I will take another look at it when I get back from vacation in two weeks.

jgrygierek commented 1 month ago

Any news?

ernestoliberio commented 1 month ago

the package is dead?

azribilel commented 3 weeks ago

Hello @acrobat, Any news ?

DennisdeBest commented 3 weeks ago

There are some changes with Symfony 6.1 which make it difficult to use 6.0 as the lowest version. I updated the composer.json to only allow symfony 6.1 and php 8.1.

The changes of some of the variables is the current Rector behaviour so we might aswell keep it like that.

If this gets merged the next thing that might have to be updated is the doctrine ORM from v2 to V3 but doing that here makes it a bit too much in one PR.

MICMathieu commented 2 weeks ago

@DennisdeBest some news about this PR ?