search

KnpLabs / KnpBundles

THE unofficial listing of Symfony2 bundles.
KnpBundles.com
223 stars 51 forks source link

Readme correct parse relative links #279

Open pilot opened 12 years ago

pilot commented 12 years ago

After parsing a readme file time to time we can catch a links inside doc's which is relative and follow to a links at the github.com, for instance http://knpbundles.com/avalanche123/AvalancheImagineBundle there are a list of relative links which follow now to the 404 page

link to the imagine lib

stloyd commented 12 years ago

Yes, I was thinking about that too some time ago. But decided to leave it for now as we not yet decide what to do with #1. But I think that in week (or two) it will clarify.

pilot commented 12 years ago

we should plan to fix this in good way to add correct links or just remove it at all for first time, cause all of this 404 links increase a total count of 404 links for knpbundles, it's not big deal, but should be perfferct to :icecream:

wysow commented 10 years ago

@pilot I think it's fixed now right ? At leat your example is working right now. Can we close this issue ?

Nek- commented 10 years ago

@wysow not at all. Checkout the license link on this page: http://knpbundles.com/sonata-project/SonataAdminBundle

wysow commented 10 years ago

@Nek- your example is that the link in the readme source is relative, all others are absolute, so maybe we should add this advice on the FAQ on the website no? @KnpLabs/knp-team what do you think about this?

I mean I think that absolute links are a good solution as this markdown files could be parsed from a lot of web services and the fact that links should be absolute could become sort of good practice...

wysow commented 9 years ago

@KnpLabs/knp-team Is someone thinking we should handle this in another way or does it sounds OK for you??

docteurklein commented 9 years ago

imho we should handle relative links. we render a gh page, it's our role to generate links correctly.

wysow commented 9 years ago

@docteurklein yes in fact you're maybe right, will try to take a look on this ASAP

akovalyov commented 9 years ago

Agree with Florian. We should handle exceptions correctly. Also note, that adding the bundle should be as fast as possible to the end user - any requirement from our side will reduce the number of bundles and not everybody will follow it.