search

KnpLabs / KnpBundles

THE unofficial listing of Symfony2 bundles.
KnpBundles.com
223 stars 51 forks source link

Allow PSR-0 and PSR-4 compliant bundles #438

Closed wysow closed 9 years ago

wysow commented 10 years ago
Q A
Bug Fix? n
New Feature? y
BC Breaks? n
Deprecations? n
Tests Pass? y
Fixed Tickets #433
License -
Doc PR

This is a functional WIP, comments are very welcome

wysow commented 10 years ago

So basically this WIP is waiting for a way to detect "real" bundles which don't use the Symfony\Component\HttpKernel\Bundle\Bundle but are extending from another bundle which use this class, @KnpLabs/knp-team someone got an idea for this ?

For example: https://github.com/Sylius/SyliusTaxonomyBundle/blob/master/SyliusTaxonomyBundle.php

docteurklein commented 10 years ago

using https://getcomposer.org/doc/04-schema.md#type for example? we can't be sure of the exact type, but it's indeed a possibility, that would match most of the bundles.

wysow commented 10 years ago

@docteurklein @KnpLabs/knp-team please feel free to review this and make comments ;)

docteurklein commented 10 years ago

the overall logic seems good to me! i dont think we can do a lot better than that :-) it surely will cover 90+% of cases

wysow commented 10 years ago

@docteurklein yep I think so too... So will work on refactoring the whole thing ;)

docteurklein commented 10 years ago

concerning those base64 checks, one possible refactor that would increase readability is to wrap the results and filter them before returning them

rcwsr commented 9 years ago

Is this still WIP? What's the status of this PR?

docteurklein commented 9 years ago

ping @wysow

wysow commented 9 years ago

This PR is waiting for code review and maybe other ideas to optimize the detection mechanism...

docteurklein commented 9 years ago

i think it has been reviewed enough. Let's improve in another PR if needed.

I'm personally +1 to merge it if you think it's ready.