search

KnpLabs / KnpMenuBundle

Object Oriented menus for your Symfony project.
http://knplabs.com
MIT License
1.4k stars 203 forks source link

sonata admin bundle not working with latest knp menu bundle version #164

Closed r-hildebrand closed 10 years ago

r-hildebrand commented 11 years ago

we already developed some application with the latest version of your knp menu bundle. now we installed the newest version of sonata admin bundle, which requires knp menu bundle 1.1.*. so far it is not working together with your newest bundle version.

for developing i use knp menu bunde 1.1.x-dev, with that sonata admin bundle is working. but some features of our knp menu bundle with the newest version is not working anymore with version 1.1.x-dev.

i will also open an issue to the sonata admin bundle maintainer. hope there will be a solution for that problem, that we can use both newest versions.

cheers ricardo

stof commented 11 years ago

The master branch of the KnpMenuBundle is the dev version for 2.0. It breaks BC with 1.1 (which is why it is a major version bump). I will not try to provide BC as it would be far too complex (the BC breaks are needed for the new features).

And the 2.0 version is not stable yet. So it seems logical to me that Sonata depends on the stable version of the bundle instead of the dev version in which BC breaks are happening (or would happen if I had time to finish what I want to do here)

mikemeier commented 11 years ago

So lets ask the right question: When will be a stable 2.X of this menu bundle?

scr4tchy commented 11 years ago

It brings problem that you work only on 1.1 as thousands of bundles massively use of the 2.X version ...

ozzmaster commented 11 years ago

@stof Here I am again!

I appreciate your feedback on the Sonata Admin Bundle project issue.

I'll see what I can do from my side to solve this problem. Don't expect much. I don't have a lot of spare time at the moment. Will have more towards the end of the year.

ozzmaster commented 11 years ago

FYI: This is the error I get when using Sonata admin bundle with the latest version of KnpMenuBundle:

PHP Fatal error: Call to undefined method Knp\Menu\MenuItem::setCurrentUri() in /[path to SF2 project]/vendor/sonata-project/admin-bundle/Sonata/AdminBundle/Admin/Admin.php on line 1393