search

KnpLabs / KnpMenuBundle

Object Oriented menus for your Symfony project.
http://knplabs.com
MIT License
1.4k stars 203 forks source link

knplabs Namespace? #9

Closed immutef closed 12 years ago

immutef commented 14 years ago

What about putting the MenuBundle into its own Bundle namespace (according to best practices from the sf2 manual). E.g. Bundle\knplabs\MenuBundle? I'd prefer that!

weaverryan commented 14 years ago

Yea, I think this has been a long time coming - Kris just namespaced his Facebook bundle - time to do it on this guy. Don't everyone rush and do it at once... :)

ornicar commented 14 years ago

This is an opensource bundle. I don't want to hardcode a brand in its namespace. Furthermore this bundle has an history. It's a port from Ryan sf1 plugin.

Iostudio-Developer commented 14 years ago

That's a fair point. I've been trying to think of a namespace that means "community", but is short and to the point. I haven't come up with anything yet. I think this bundle - with several of us already participating, would be a good "community-official" bundle, if we could think of a good name.

weaverryan commented 14 years ago

FYI - the above is me - forgot to log out of our work dev account.

ornicar commented 13 years ago

So the knplabs devs have applied the knplabs namespace. As the creator of this bundle, I disagree. This bundle is nothing more than a quick port of the awesome menu library created by Jon Wage and maintained by weaverryan and other fellows. It's absolutely unfair to give it the Knplabs namespace. The only acceptable namespace for this bundle is FOS.

ornicar commented 13 years ago

I have an idea. As the menu library is the work of a community, it should move to FOS. But knplabs can "own" the SF2 integration.

So my proposal is to extract the menu library from this bundle. It is possible as it is standalone. This menu library goes to FOS\Menu. Knplabs can then keep Knplabs\MenuBundle, which requires FOS\Menu as a dependency, and ensure its integration to SF2.

weaverryan commented 13 years ago

I think having the Menu library as a standalone library is a great idea and would really reinforce the mission of that library. Of course, the problem is that it's not an external dependency that the user will need to install when using this bundle. I'm still for it being broken out, but we at least need to think about the extra pain of installation.

stof commented 12 years ago

@weaverryan can this be closed or no ?

weaverryan commented 12 years ago

+1 for closing this. There were some good points here, but nothing worth breaking BC at this point. It made more sense a year ago when the issue was opened, but not now :).