KnpLabs / KnpRadBundle

Rapid Application Development for Symfony2 [UNMAINTAINED]
MIT License
291 stars 49 forks source link

We need a new stable release #177

Closed akovalyov closed 10 years ago

akovalyov commented 10 years ago

@docteurklein the latest release is 2.3.2(actually, GitHub shows v2.3.1 as latest) which is incompatible with stable symfony 2.5.0 Knp\RadBundle\Controller\Controller::createAccessDeniedException->createAccessDeniedException() has another access level than https://github.com/symfony/symfony/commit/183d0ec302d3eece21a8f8766c899641132cedeb

docteurklein commented 10 years ago

ho, thanks for pointing this out!

I'll try to do that ASAP, but I haven't much time right now.

docteurklein commented 10 years ago

I just removed this method, since it as already defined in the base class.

Can you tell me if it fixes the probkem for you ? If so, I'll tag a new release.

akovalyov commented 10 years ago

@docteurklein I would be happy to say that it fixes the problem

diff --git a/composer.json b/composer.json
-        "knplabs/rad-bundle": "~2.3@dev",
+        "knplabs/rad-bundle": "dev-develop as ~2.3@dev",

I am just using clean RAD edition, cloned this night When I open the homepage - I get

ServiceCircularReferenceException: Circular reference detected for service 
"knp_rad.domain_event.dispatcher.delayed", path: "knp_rad.domain_event.dispatcher.delayed -> 
doctrine.dbal.default_connection.event_manager".
docteurklein commented 10 years ago

this is another issue, #163

akovalyov commented 10 years ago

@docteurklein so we can not have the release at the moment since c9f7b0b5eb0654e09720b2651902365fa7b2d8b3(which is parent commit for https://github.com/KnpLabs/KnpRadBundle/issues/163#issuecomment-38379197) does contain the same Knp\RadBundle\Controller\Controller::createAccessDeniedException->createAccessDeniedException() :(

docteurklein commented 10 years ago

I just pushed a new tag: 2.5.0

docteurklein commented 10 years ago

BTW, we need to be more semver compliant, because currently: noidea

docteurklein commented 10 years ago

closing for now. thanks!