search

KnpLabs / KnpTimeBundle

Provides helpers for time manipulation
http://knplabs.com
MIT License
602 stars 105 forks source link

Move `symfony/templating` to dev dependencies #179

Closed GromNaN closed 1 year ago

GromNaN commented 1 year ago

symfony/templating is already an optional dependency. There's no reason to force its installation when even symfony/twig-bundle isn't required.

https://github.com/KnpLabs/KnpTimeBundle/blob/db453621e84ef0b73905d98ff4bd21a1c8396101/src/DependencyInjection/KnpTimeExtension.php#L23-L25

This component might be deprecated https://github.com/symfony/symfony/pull/51144

kbond commented 1 year ago

This was done in https://github.com/KnpLabs/KnpTimeBundle/pull/141 but reverted in https://github.com/KnpLabs/KnpTimeBundle/pull/172 because of https://github.com/KnpLabs/KnpTimeBundle/issues/171.

GromNaN commented 1 year ago

The twig extension is also depending on a twig class, but that's not an issue with symfony/twig-bundle as a dev dependency.

kbond commented 1 year ago

I know... not sure why it was reverted.

weaverryan commented 1 year ago

I'm thinking that we merge this, #178 and #177 and do a 2.0 release. Then it's no worries either way.

weaverryan commented 1 year ago

Done now in #178 :)