search

KnpLabs / knp-components

Various component pack, includes paginator
MIT License
745 stars 141 forks source link

PaginationInterface lacks getCustomParameters method #310

Closed stollr closed 1 year ago

stollr commented 2 years ago

The PaginationInterface has a setCustomParameters method, but no getCustomParameters method. The getCustomParameter allows us to get a param, but only if you have a sepcific key. It is not possible to get all params at once.

What do you think, should we add it to the interface in the next major? With a deprecation notice if the implementing class does not have such a method.

garak commented 1 year ago

I can't see the benefit of adding configuration-related methods to the interface.