search

KnpLabs / knp-components

Various component pack, includes paginator
MIT License
751 stars 141 forks source link

v4 #314

Closed garak closed 2 years ago

garak commented 2 years ago

This is a big refactoring, that allows decoupling from the Symfony Request object. This will allow paginating outside the web context (for example, in a console application). A layer of compatibility with Request is provided, but the signature of Pagination had to be changed, so this is meant to be released in a major version (v4.0.0)

alexpozzi commented 2 years ago

I still didn't have time to go for a full review but I like the change you are proposing. I'm not so sure I'll be able to find some time before the end of the next week so, since you are the maintainer, if you want to merge and release this change it's fine with me :wink: