KnpLabs / packagist-api

PHP API for Packagist
MIT License
182 stars 46 forks source link

fix: getComposer method #79

Closed JellyBellyDev closed 2 years ago

JellyBellyDev commented 2 years ago

Fixed #76 I hope :)

JellyBellyDev commented 2 years ago

I don't know why the CI doesn't pass, suggestions?

robbieaverill commented 2 years ago

Hi @JellyBellyDev, still working on this - I've made a couple of potential changes and am working on the tests, will post an update when I can.

robbieaverill commented 2 years ago

I've tested this against the behaviour in 1.7.x using the original getComposer() method added in https://github.com/KnpLabs/packagist-api/commit/37a9b1ec6f20e6e7c3ad8648f263f1dfd2e1662a, and have put the original doc block (slightly adjusted) from that commit back in place. All looks good to me now. Thanks for your contribution @JellyBellyDev and sorry again for the time it took for me to review it.