search

KnuffApp / Knuff

The debug application for Apple Push Notification Service (APNs).
MIT License
5.24k stars 437 forks source link

Support APNS with Token Authentication #62

Open JanC opened 7 years ago

JanC commented 7 years ago

Hi, Apple supports JWT token authentication and I was wondering if there is a plan to add this to the Knuff app. If no, what would be the contribution guidelines?

Reference:

cheers

blommegard commented 7 years ago

Yes, this is very high up on my want-list for Knuff! This fall have been crazy and the time haven't been here for Knuff. I will try to have a look at pull requests and merge/comment on them asap, so they are very welcoming!

JanC commented 7 years ago

ok great, I'll be happy to contribute as I use Knuff a lot. I'll create a PR if I have time to implement this

JanC commented 7 years ago

Hi, Just for the record, I started this ticket in the JWT library because it's something that will be needed for this feature.

https://github.com/yourkarma/JWT/issues/116

blommegard commented 7 years ago

@JanC What is the status of https://github.com/yourkarma/JWT/issues/116 nowadays?

JanC commented 7 years ago

Funny that you ask because I was wondering that as well :) I started to have a look at other solutions such as https://github.com/vapor/vapor-jwt

but it also does not work out of the box with Apple's keys apparently https://github.com/vapor/jwt/issues/47

blommegard commented 5 years ago

https://github.com/ethanhuang13/CupertinoJWT seems to be the best alternative to date.