search

KnugiHK / WhatsApp-Chat-Exporter

A customizable Android and iOS/iPadOS WhatsApp database parser that will give you the history of your WhatsApp conversations in HTML and JSON. Android Backup Crypt12, Crypt14, Crypt15, and new schema supported.
https://wts.knugi.dev/
MIT License
521 stars 76 forks source link

Provide reasons for "message not supported" #39

Closed AlexanderRitter02 closed 1 year ago

AlexanderRitter02 commented 1 year ago

Description

Hi, WhatsApp meta messages like:

are currently treated as "This message is not supported".

As noted in this comment, it's not a bug: https://github.com/KnugiHK/Whatsapp-Chat-Exporter/issues/9#issuecomment-1427487785

Metadata is also treated as messages in the database. But since it is not the main focus when it comes to exporting chats, metadata may show as "not supported" unless handled like changes of the group name. Therefore, I will consider it not a bug if the chat is complete.

This is mostly fine, but can cause concern among users thinking some messages are missing (and not everyone searches Github to find the issue).

Suggestion

I suggest additionally providing the reason why the message is not supported (e.g. deleted message or whatsapp internal message) instead of the generic comment that the message is not supported.
This will make it clear that the message is not important.

It would be useful to alleviate the concerns of missing messages if looking through the backup at a later time.

You do detect that these messages are unsupported, so if individually detecting the type is infeasible, an option would also be to make the message less intimidating: A Whatsapp internal message (phone changed, deleted messages, ...) is not supported

KnugiHK commented 1 year ago

"This message was deleted" is supposed to be handled. At least it is handled before we move to the new schema. Therefore, it should be considered a bug.

I agree we can add the reason why certain messages are not supported. On the other hand, we can also hide the metadata messages from the output. What do you think?

KnugiHK commented 1 year ago

The missing of "Message deleted" should be fixed in c7a01bb.

kintaro1981 commented 1 year ago

I can confirm that "Message deleted" is fixed, I just tried with a iOS db.

How about supporting the other ones like, " has left the group"?

I want to use Whatsapp-Chat-Exporter to archive many of my WA chats and free up space in the phone, but I would like in the future, for example, to know when a user left a group.

KnugiHK commented 1 year ago

I can confirm that "Message deleted" is fixed, I just tried with a iOS db.

How about supporting the other ones like, " has left the group"?

I want to use Whatsapp-Chat-Exporter to archive many of my WA chats and free up space in the phone, but I would like in the future, for example, to know when a user left a group.

More metadata will be supported in the future, I assume. But since parsing metadata requires understanding their binary representation, there is yet to be a timeline for their implementation.

KnugiHK commented 1 year ago

I can confirm that "Message deleted" is fixed, I just tried with a iOS db. How about supporting the other ones like, " has left the group"? I want to use Whatsapp-Chat-Exporter to archive many of my WA chats and free up space in the phone, but I would like in the future, for example, to know when a user left a group.

More metadata will be supported in the future, I assume. But since parsing metadata requires understanding their binary representation, there is yet to be a timeline for their implementation.

FYI, 011c8ff implemented a metadata handling related to missed calls.

KnugiHK commented 1 year ago

Another FYI, 3ed269e & 030fef5 introduced a lot of metadata handling for Android.

KnugiHK commented 1 year ago

Released in 0.9.5.