search

KnugiHK / WhatsApp-Chat-Exporter

A customizable Android and iOS/iPadOS WhatsApp database parser that will give you the history of your WhatsApp conversations in HTML and JSON. Android Backup Crypt12, Crypt14, Crypt15, and new schema supported.
https://wts.knugi.dev/
MIT License
518 stars 76 forks source link

Add support for separating media files per chat #93

Closed mmmeeedddsss closed 2 months ago

mmmeeedddsss commented 2 months ago

I have added a flag to create a duplicate of the existing media grouped by chat.

This was my own need, and saw many people online asking for a similar ability, so I decided to open a PR in here to make that available for public use.

I have tested the change with my own backup and it is working. If you accept the PR, I'll also open another PR on the wiki section for updating the usage.

Thank you for the great repository!

KnugiHK commented 2 months ago

Hi. Thanks for your contribution first, I will review and test the changes later.

Are there any specific issues opened? If so, please let me know so that I can link the issues to this PR.

mmmeeedddsss commented 2 months ago

This was originally my own need, but I can see the following related issue too: https://github.com/KnugiHK/WhatsApp-Chat-Exporter/issues/88

mmmeeedddsss commented 2 months ago

@KnugiHK Also, should I rebase my commit to dev branch and open the PR from there? Maybe it is better to test once again with my changes on top of dev branch and let you know!

KnugiHK commented 2 months ago

@KnugiHK Also, should I rebase my commit to dev branch and open the PR from there? Maybe it is better to test once again with my changes on top of dev branch and let you know!

Yes, please.

mmmeeedddsss commented 2 months ago

Hey hey ! Thank you @KnugiHK once again for your responsivness. I just updated the base branch to dev, merged my changes to dev branch and made the necessary adjustments. It is now running on my local PC with my own android whatsapp db. (mmmeeedddsss:main now contains the KnugiHK:dev + my commit for the feature)

FYI:

KnugiHK commented 2 months ago

I have mistakenly removed the LICENCE.django file you put

I will add that back later.

Incremented the version to 0.10.0. This is a new feature but it is backward compatible so incrementing the minor version seemed ok to me.

Although the PR itself cannot "own" a version, the next release will be 0.10.0, which is drafted already :), and your PR will probably be included in this version. Therefore, I will leave the version string unchange.

Btw, I read the code but I still haven't had time to test it with a database, I will finish the review ASAP.

destaa commented 2 months ago

I did some changes. Could you please test it again with your database?

is this works with chat group as well?

destaa commented 2 months ago

and forgive me, I'm new in github.. as far as I know, KnugiHK has approved mmmeeedddsss's PR, and KnugiHK has commit of the new parser of --create-separated-media. I thought I can execute the new parser with cloning KnugiHK's dev branch again, with the fresh one. But it isn't working. What did I miss? should it be merged to dev branch first so I can execute with my database?

KnugiHK commented 2 months ago

I did some changes. Could you please test it again with your database?

is this works with chat group as well?

It should works with group chat.

I thought I can execute the new parser with cloning KnugiHK's dev branch again, with the fresh one. But it isn't working. What did I miss? should it be merged to dev branch first so I can execute with my database?

I approved the changes but the commits are not yet being merged.

KnugiHK commented 2 months ago

@destaa If you want to try it first, install the exporter with pip install git+https://github.com/mmmeeedddsss/WhatsApp-Chat-Exporter.

destaa commented 2 months ago

@destaa If you want to try it first, install the exporter with pip install git+https://github.com/mmmeeedddsss/WhatsApp-Chat-Exporter.

nice i'll try..thanks

mmmeeedddsss commented 2 months ago

@KnugiHK Sorry for my late response. Thank you for your review and patches. Also, I'm happy to see your implementation on IOS too!

The current state works well on my local database too. I think it is okay to merge this if you don't have any additional feedback or things to do.

KnugiHK commented 2 months ago

@KnugiHK Sorry for my late response. Thank you for your review and patches. Also, I'm happy to see your implementation on IOS too!

The current state works well on my local database too. I think it is okay to merge this if you don't have any additional feedback or things to do.

LGTM! Thanks for your contribution again!