search

KnutZuidema / golio

League of Legends, Legends of Runeterra and Valorant API client library for Go
MIT License
73 stars 29 forks source link

fix(api): use champions cache for list only when list was executed previously #25

Closed KnutZuidema closed 4 years ago

KnutZuidema commented 4 years ago

when calling GetChampion a single champion will be added to the cache previously GetChampions only checked if the cache was completely empty and if not used the cache for the return value this caused the method to return incomplete data if GetChampion was called before calling GetChampions

resolves #24

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         806    806           
=====================================
  Hits          806    806
Impacted Files Coverage Δ
api/data_dragon.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c5ba48...7702f7c. Read the comment docs.