Closed ironpark closed 4 years ago
This is undocumented behavior of the League API then I guess? I'm fine with implementing those attributes here, but I'd like to do it in a way that makes it clear that it's not officially documented and thus might change at any time.
This is undocumented behavior of the League API then I guess? I'm fine with implementing those attributes here, but I'd like to do it in a way that makes it clear that it's not officially documented and thus might change at any time.
right it is undocumented behavior. In general, if you use a specification that is not defined in the API documentation, it can be changed at any time, and we understand that compatibility is not guaranteed, but given that the issue has been neglected for a long time. this issue seems to have been opened around March 2019
I know how you are going to manage and maintain your project. I respect it and I think it is the right direction. so... for the usecase I need, I will create a separate implementation or proceed through fork.
Thank you,
I'll gladly accept a pull request, if you wanna push those changes upstream.
statPerk0,statPerk1,statPerk2
statPerk0,statPerk1,statPerk2 dose not define "ParticipantStatsDto" from api document getMatch API
However, the response results include statPerk0, statPerk1, and statPerk2, which are necessary to record the total rune information for each player.
API response example (participants part)
Proposed changes
Since English is not my native language, there may be awkward or misleading expressions.