Match v5

[pixelrazor]

This is the initial implementation of adding support for Matches v5. The Match Timeline endpoint wasn't updated YET, i pllan to do so once i get better documentation for it. Also, i think they plan to add filtering for begin/end times for getting the match list, but it doesn't exist as of yet. The match IDs returned by the spectator endpoint no longer matches what we need for matches v5, so a conversion has been added until we get an updated spectators endpoint. During my testing, i noticed a few issues that i fixed:

• datadragon now uses a slightly different base url
• The ID values returned by the riot api map to the Key field of a lot of datadragon responses, not ID
• More idiomatic usage of channels
• Fix the types for string constants
• Add a workaround to the profileicons.json's bizarre response

[codecov[bot]]

Codecov Report

Merging #49 (69d3e37) into master (c51c530) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          821       817    -4     
=========================================
- Hits           821       817    -4     

Impacted Files	Coverage Δ
datadragon/data_dragon.go	100.00% <100.00%> (ø)
datadragon/model.go	100.00% <100.00%> (ø)
riot/lol/match.go	100.00% <100.00%> (ø)
riot/lol/model.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c51c530...69d3e37. Read the comment docs.

[pixelrazor]

Docs are up for the MatchDto, and will get added here soon. The timeline data doesn't have docs yet though, and that's a beast of an object. v4 deprecation is looking like it is sep 27th, so hopefully this can be ready soon

[barqus]

Hi guys, sorry for bothering, do you know when this feature will be in the production? Thanks for the response!

[pixelrazor]

I hope to update a lot of it soon when I get the time, but there's still no documentation for the match timeline data. Once I update the other models and endpointa, you can use my branch if you need match v5 data (outside of timeline data)

[pixelrazor]

Hi guys, sorry for bothering, do you know when this feature will be in the production? Thanks for the response!

I jsut updated all of the d ocumented structs and added the new parameters for listing match IDs. The only remaining thing SHOULD be the timeline, which is still lacking documentation (and i don't have the time to parse out that whole struct by hand currently). I believe that the current struct (v4 timeline) should cover a lot of it though

[KnutZuidema]

Hi @pixelrazor, sorry for the long wait. It looks like the linter doesn't like some of you changes, please have a look at that.

[pixelrazor]

Hi @pixelrazor, sorry for the long wait. It looks like the linter doesn't like some of you changes, please have a look at that.

I think i addressed the lint issues

[KnutZuidema]

@pixelrazor thank you very much for your contribution!