KnutZuidema / golio

League of Legends, Legends of Runeterra and Valorant API client library for Go
MIT License
73 stars 29 forks source link

Dev #54

Closed yigithanbalci closed 1 year ago

yigithanbalci commented 1 year ago

fix for issues:

yigithanbalci commented 1 year ago

I have updated it according to your review. But I couldn't figure out why the pipeline is lingering.

codecov[bot] commented 1 year ago

Codecov Report

Merging #54 (a880405) into master (fe6add7) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #54    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           21        27     +6     
  Lines          817       955   +138     
==========================================
+ Hits           817       955   +138     
Files Coverage Δ
golio.go 100.00% <ø> (ø)
internal/client.go 100.00% <100.00%> (ø)
riot/lol/challenges.go 100.00% <100.00%> (ø)
riot/lol/client.go 100.00% <100.00%> (ø)
riot/lol/match.go 100.00% <100.00%> (ø)
riot/lol/model.go 100.00% <100.00%> (ø)
riot/lol/third_party_code.go 100.00% <100.00%> (ø)
riot/lol/tournament.go 100.00% <100.00%> (ø)
riot/val/client.go 100.00% <100.00%> (ø)
riot/val/content.go 100.00% <100.00%> (ø)
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yigithanbalci commented 1 year ago

Not all linting problems were showing at once, therefore I have run CI in my forked branch and merged changes to my dev branch which was the merging branch for this PR. I guess this time it should pass all controls in the pipeline

KnutZuidema commented 1 year ago

Thanks a ton @yigithanbalci for your work. 🙏