search

KnutZuidema / golio

League of Legends, Legends of Runeterra and Valorant API client library for Go
MIT License
72 stars 29 forks source link

added byPuuid and byRiotId from https://developer.riotgames.com/apis#account-v1 #59

Closed ghost closed 7 months ago

ghost commented 10 months ago

Hello, I have noticed that the GET getByPuuid and GET getByRiotId endpoints are missing. These endpoints are expected to replace the getBySummonerName functions from the summoner v1 and v4.

I hope everything I have done is correct :)

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dbe1751) 100.00% compared to head (af21ae5) 100.00%.

:exclamation: Current head af21ae5 differs from pull request most recent head 35c27d1. Consider uploading reports for the commit 35c27d1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 27 29 +2 Lines 955 976 +21 ========================================= + Hits 955 976 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KnutZuidema commented 7 months ago

closing this in favor of #60