search

KnutZuidema / golio

League of Legends, Legends of Runeterra and Valorant API client library for Go
MIT License
73 stars 29 forks source link

Add new RiotID routes; Capture RiotIDGameName from MatchV5 #60

Closed harmonherring closed 6 months ago

harmonherring commented 10 months ago

Since it seems #59 is dead I've opened this PR. It's pretty much identical besides a few minor fixes

KnutZuidema commented 9 months ago

@harmonherring, not sure how it got in there, but the commit refactor: test response body does not belong here. You can drop it from the branch.

Nico-Mayer commented 9 months ago

Riot also stated in this article that

endpoints are deprecated from now on, so it may be a good idea to include a comment on this.

Nico-Mayer commented 7 months ago

@KnutZuidema are there plans to merge this MR in the near future?

harmonherring commented 7 months ago

@KnutZuidema apologies for the delay on this 😅 I've implemented the account methods directly on Client as you asked and also rebased that odd commit out of history

harmonherring commented 7 months ago

Riot also stated in this article that

  • /lol/summoner/v4/summoners/by-name/{summonerName}
  • /tft/summoner/v1/summoners/by-name/{summonerName}

endpoints are deprecated from now on, so it may be a good idea to include a comment on this.

I agree, let's do this in a separate PR 😄