Ko-Khan / pe

0 stars 0 forks source link

Pairing and unpairing is done by index, but index of partner is not shown #3

Open Ko-Khan opened 2 months ago

Ko-Khan commented 2 months ago

Screenshot 2024-04-19 162344.png

Pairing and unpairing is done using person's index in list. However, this is not displayed on person card, so this information can be hard to find. This may make pairing and unpairing cumbersome for user if they were to have large amounts of data stored in Elder Scrolls, as they will have to look for the index number for each party they want to unpair. While find command can help, this command does not stand on its own

nus-pe-bot commented 2 months ago

Team's Response

Please refer:

image.png

In Elder Scroll's DG, we have covered this optimization issue under our planned enhancements:

image.png

On these grounds in accordance to CS2103T's guidelines, we believe the bug should be rejected.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This was not the issue I was bringing up. My point was not regarding the error messages but the use of index numbers in pairing and unpairing. For example, you could either use the person's name instead or display the partner's index number alongside their name. The problem with the current implementation for me is that to use the pair or unpair command, the user has to almost always use find command beforehand if dataset is too large, which makes workflow longer than it needs to be.

From what I saw in your developer guide, you were addressing the output of the pair/unpair command when it comes to errors, which was not what I was bringing up.