Ko-Khan / pe

0 stars 0 forks source link

Phone number verification #7

Open Ko-Khan opened 2 months ago

Ko-Khan commented 2 months ago

Screenshot 2024-04-19 170809.png While phone numbers that are too short are checked, this is not extended to those that are too long

soc-se-bot commented 2 months ago

Team's Response

We have made a deliberate decision to accept long phone numbers in an effort to accommodate international phone numbers, some of which (like Australia's) can extend to up to 15 digits. In addition, we leave it up to the user to decide whether they wish to save phone numbers with their country code as well, which further increases the length of the number and makes setting a strict phone digit cutoff quite difficult.

You are right in pointing out that we should not accept phone numbers of an infinite length, which can definitely be improved upon in the future, but currently we believe that allowing the user more freedom is better than potentially not accepting valid phone number formats for the sole reason of wanting to guard against potentially malicious actors.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]