KoBeWi / Metroidvania-System

General-purpose framework for creating metroidvania games in Godot.
https://godotengine.org/asset-library/asset/2301
MIT License
1.06k stars 51 forks source link

Issue with room name not in assigned scenes (sample project) #48

Closed XanderDesai closed 5 months ago

XanderDesai commented 6 months ago

Hey there! I'm starting out with a fresh clone of this repo and trying to run the sample project.

Immediately upon running the program I'm getting an assertion error here https://github.com/KoBeWi/Metroidvania-System/blob/master/addons/MetroidvaniaSystem/Scripts/MapData.gd#L488

The error is that my room name :cv55nv1c2sbiq is not in assigned_scenes. The assigned_scenes dictionary is mostly human readable tscn filenames. there are a couple UIDs in that dict but none of them match the one that I have in the room_name variable.

Godot version 4.2. Windows 10. I haven't made any changes other than cloning the repo and pressing run.

bybywudi commented 6 months ago

I encountered the same issue as you

KoBeWi commented 6 months ago

I can't reproduce it. Just tried a fresh clone in Godot 4.2.2.

Maybe you have some old save file? Remove example_save_data.sav from user data directory if it exists.

PotatoGuy123 commented 5 months ago

I have the same problem, with also with a fresh clone

PotatoGuy123 commented 5 months ago

I can't reproduce it. Just tried a fresh clone in Godot 4.2.2.

Maybe you have some old save file? Remove example_save_data.sav from user data directory if it exists.

I'm sorry im kind of dumb, where would i find this?

KoBeWi commented 5 months ago

In the top editor menu: Project -> Open User Data Folder.

PotatoGuy123 commented 5 months ago

i've checked the whole folder, and it doesn't look like it exists in there. If it helps any, I have the same issue on both my pc and on my laptop

KoBeWi commented 5 months ago

I don't know then. Are you using newest Godot stable with newest version of MetSys (available from GitHub)? If the scene is not found in assigned scenes, what scenes are registered?

PotatoGuy123 commented 5 months ago

I'm using godot 4.2.2, and I am 99% sure im using the latest version of metsys, as I am creating a clone through using the github desktop. As for the registered scenes, I used a print statement right above the assert and this was the output

image

KoBeWi commented 5 months ago

Can you provide stack trace for the error call? Your room name does not exist in the map data, I don't know where it came from.

PotatoGuy123 commented 5 months ago

I hope this is what your looking for, im still relatively new to Godot, so please let me know if it was something else you needed instead

image

KoBeWi commented 5 months ago

Ok this is the same issue as #8 Which is weird, because I fixed it 🤔 I'll look into it again. In the meantime you can try opening MapData.txt and converting line endings manually (your code editor/IDE should have such option, if you have one).

PotatoGuy123 commented 5 months ago

alright, thanks

KoBeWi commented 5 months ago

Fixed in 8224a33