KoalaBotUK / KoalaBot

🐨 All in one Discord bot for student societies & communities
https://KoalaBot.uk
MIT License
11 stars 8 forks source link

Feature/verify api #405

Closed JayDwee closed 1 year ago

JayDwee commented 1 year ago

Summary

close #397

Checklist



codecov[bot] commented 1 year ago

Codecov Report

Merging #405 (0f8d07b) into master (44492c8) will decrease coverage by 0.04%. The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   87.39%   87.35%   -0.04%     
==========================================
  Files         119      123       +4     
  Lines        8750     8916     +166     
==========================================
+ Hits         7647     7789     +142     
- Misses       1103     1127      +24     
Flag Coverage Ξ”
unittests 87.35% <90.47%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
koala/cogs/announce/db.py 100.00% <ΓΈ> (ΓΈ)
koala/cogs/colour_role/cog.py 88.10% <ΓΈ> (ΓΈ)
koala/cogs/colour_role/models.py 88.88% <ΓΈ> (ΓΈ)
koala/cogs/react_for_role/api.py 91.66% <ΓΈ> (ΓΈ)
koala/cogs/react_for_role/utils.py 100.00% <ΓΈ> (ΓΈ)
koala/cogs/twitch_alert/env.py 100.00% <ΓΈ> (ΓΈ)
koala/cogs/twitch_alert/models.py 92.68% <ΓΈ> (ΓΈ)
koala/cogs/verification/env.py 100.00% <ΓΈ> (ΓΈ)
koala/env.py 81.25% <ΓΈ> (ΓΈ)
tests/cogs/base/test_cog.py 100.00% <ΓΈ> (ΓΈ)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

abluey commented 1 year ago

All the code looks good, though is db file really needed in verification? I moved the blacklist stuff there but every other db action was executed in core anyway πŸ€”