Closed sunny-chung closed 7 months ago
gsteckman
commented
7 months ago I can't run this without your data. But are you putting the graph in a vertically scrollable area without otherwise restricting the height of the graph, e.g. by using a modifier?
sunny-chung
commented
7 months ago Yes. Is this not supported?
gsteckman
commented
7 months ago The graph will expand to consume all available space, so if you put it in a scrollable column the vertical space is infinite - and by inspecting the code I think that will lead to what you are seeing (I didn't try it but there's a calculation that divides by the available space to find the relative tick spacing, which would result in it being 0 - in any case you probably don't want an infinitely tall graph).
If you use a Modifier to set a max height or aspect ratio, this exception will likely go away.
On Mon, Feb 26, 2024 at 7:33 PM sunny-chung @.***> wrote:
Yes. Is this not supported?
— Reply to this email directly, view it on GitHub https://github.com/KoalaPlot/koalaplot-core/issues/42#issuecomment-1965725769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGOGXZGYXJDJ2OSPWRMSMILYVVHZNAVCNFSM6AAAAABD2UCZLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVG4ZDKNZWHE . You are receiving this because you commented.Message ID: @.***>
sunny-chung
commented
7 months ago Thanks for the prompt response. I overcame this error, and encountered more errors.
autoScaleYRange() when there is no pointThen, I took an hour to figure out how to reduce minor grid lines.
I encountered an exception when I try to reduce number of grid lines in x-axis by reducing number of items in CategoryAxisModel.
And then, I changed to use LinearAxisModel, which only accepts Float values. My data are timestamps, so they are in Long. I keep encountering an error IllegalArgumentException: Axis range end (1.70904125E12) must be greater than start (1.70904125E12), even if I hardcoded things in the below code. Because x - 2000 and x has the same value after converting to Float, which is a low-precision data type.
val pseudoPoints = points.ifEmpty {
val now = KInstant.now().toMilliseconds()
listOf(DefaultPoint(now - 2000, 0f), DefaultPoint(now, 0f))
}.let {
if (it.size == 1) {
listOf(DefaultPoint(it.first().x - 2000, it.first().y), it.first())
} else {
it
}
}
val floatPoints = points.map { DefaultPoint(it.x.toFloat(), it.y) }
XYGraph(
xAxisModel = LinearAxisModel(
pseudoPoints.first().x.toFloat() .. pseudoPoints.last().x.toFloat(),
minorTickCount = 0,
minimumMajorTickIncrement = 2000f,
),
yAxisModel = LinearAxisModel(
pseudoPoints.autoScaleYRange(),
minorTickCount = 2,
),And autoScaleXRange() is only available for Float values.
Even if there is no IllegalArgumentException throwing, I would have to deal with precision loss issues raised by conversion from Long to Float and then back to Long.
This is a great library. I like the customizable styles and designs even though they are deeply buried and not documented. The look and feel is also okay. Also I like the compose-style APIs, which cannot be found in other alternatives. I wish the documentation on getting started could be better, the library could provide more friendly APIs and not coupled to one low-precision inflexible data type. Many of the exceptions I encountered can be avoided with a few lines of documentation. I may have to look for alternatives due to the floating point issues.
Please correct me if I did not understand the library well, so that I can still explore this library.
gsteckman
commented
7 months ago Thanks for the feedback, this is useful for helping to make the library better and understanding how people want to use it. Have you seen the documentation here https://koalaplot.github.io/docs/? If specific things are missing in the documentation that caused you trouble, please let me know so we can add more information on those topics.
With regards to the data types, that is something that should be fairly easy to add - I'll look into it. I was using Float myself, and and didn't create versions for every data type and was waiting for interest from other users. Since the Number class has no arithmetic operators, it's not as straightforward as just adding a generic type to the existing implementation.
The ClassCastException looks like a bug. The xychart.* classes/functions are deprecated and I plan to remove them in 0.6.0 - I'll do that soon.
Autoscaling will need at least 2 points to compute a scale. I don't know of a way to get the compiler to enforce that.
sunny-chung
commented
7 months ago Glad to hear you will look into the data types! I can't wait to see your updates.
For the term "documentation" I used, I am referring to https://koalaplot.github.io/docs/ and javadocs.
autoScaleXRange() requires an non-empty list.But I think it is an API design rather than a documentation issue. Perhaps autoScaleXRangeOrElse(default: ClosedFloatRange) to handle exceptional cases.
ClassCastExceptionI expect import statements with full package names should be specified in the examples in documentation when there are multiple classes with the same names. It would be cool if you would remove the duplicates, but not specifying deprecated stuffs and not annotating with @Deprecated is also an issue.
Nowhere I could find in the documentation. I expect it is inside "Getting Started", "XY Graphs", or a dedicated section of "Look and feel". Documentation did mention "removing minor ticks", but that is different from "decreasing number of minor grid lines".
autoScaleXRange() is only available for Float values.Also not in documentation.
Minimum tick spacing must be greater than 0 and less than or equal to 1I expect "graph cannot be wrapped in an infinite scrollable container" or "maximum height needs to be limited" is documented somewhere near "Getting Started" or in README. Users seeing this limitation would probably not encounter this exception.
For javadocs issue, I expect there are descriptions for the parameters of rememberAxisStyle(), rather than guessing from the outcomes. Nevertheless, I can see there are javadocs for most of the classes and functions I used in KoalaPlot, which are good.
Since the Number class has no arithmetic operators
Yes, this is one of the limitation in Kotlin. There are type conversions in arithmetics. But I believe custom (operator) functions can be written, as the number of subclasses are discrete, and we don't have to handle all the possibilties. For example, this is working:
operator fun Number.plus(another: Number): Number {
if (this is Int && another is Int) {
println("working")
return this + another
}
return 0
}
fun main() {
val a: Number = 1
val b: Number = 2
println(a + b)
}It would be great if BigDecimal / BigNumber can be supported as well. I encountered these data types in some projects. But it is not multiplatform, and I have not yet seen a good alternative multiplatform implementation.
gsteckman
commented
7 months ago I just pushed a change adding LongLinearAxisModel (as well as for other data types) and addressing some of the other issues. It's not been heavily tested so give it a try and if you encounter bugs please open a new issue for each one.
The minor grid lines are tied to the minor ticks - there is 1 minor grid line for each minor tick. If you change the number of minor ticks it also changes the number of minor grid lines. I don't think I've ever seen a graph where the number of minor grid lines was different than the number of minor ticks (you can also change the length of minor ticks and set it to 0 if you don't want them to show, in which case you'll only see a change in the number of minor grid lines). If you have an example of what you are trying to achieve I'll take a look at it.
I got an exception when trying to display a XYGraph. I thought it was related to empty data, so I ensure there are some data but still in vain. How to avoid errors to display the chart correctly?
Version: 0.5.2 Target Platform: Desktop
Stacktrace:
Reproducer: