search

KoalaSat / nostros

Nostr client on Android
Apache License 2.0
408 stars 30 forks source link

Include open source QR reader #468

Open KoalaSat opened 1 year ago

KoalaSat commented 1 year ago

We want to add an open source de-googled QR reader. Recently we added:

It can be tested by doing these changes:

Any other well maintained QR reader library is a good option as far it's FOSS and de-googled. It looks like the app Conversations (XMPP) makes use of a valid QR reader library.

Rewarded with 300K Sats ⚡ drop a comment below if you want to be assigned.

b4s36t4 commented 1 year ago

Maybe create a plugin for react-native-camera using zxing or https://github.com/LazarSoft/jsqrcode should be a de-googled package right?!

MauroJr commented 9 months ago

@KoalaSat I would love to work on this one! Can you assign it to me?

KoalaSat commented 9 months ago

Done @MauroJr ! We have a FOSS validator that is run on every build. Make sure you run it before working on the details to validate the library of your choice is fully FOSS 🙂

KoalaSat commented 9 months ago

More details here: https://github.com/KoalaSat/nostros/blob/main/.github/workflows/android-build.yml#L34

b4s36t4 commented 9 months ago

@KoalaSat Can I also work on this?

KoalaSat commented 9 months ago

Hi @b4s36t4 , sorry but usually we assign bounties to only one person, if you are interested, you can also check this one, wich is pretty much similar https://github.com/KoalaSat/nostros/issues/465

MauroJr commented 9 months ago

@KoalaSat Thank you for assigning it to me. I hope can help.

I'm working on it outside of my working hours which is GMT -5.

I already made a good part of it and I should have a PR Tomorrow before I finish my day, very late in the evening.

After I push it, I'll be happy to get feedback and discuss the implementation.

KoalaSat commented 9 months ago

@KoalaSat Thank you for assigning it to me. I hope can help.

I'm working on it outside of my working hours which is GMT -5.

I already made a good part of it and I should have a PR Tomorrow before I finish my day, very late in the evening.

After I push it, I'll be happy to get feedback and discuss the implementation.

No rush :) take your time!