Kobot7 / pe

0 stars 0 forks source link

"Battling Command" Sequence diagram: Extra action bar should be shown for function call to same class #13

Open Kobot7 opened 2 months ago

Kobot7 commented 2 months ago

Problem

Under section Battling Component, the sequence diagram should have a second action bar when calling a function from the same class.

image.png

nus-se-script commented 2 months ago

Team's Response

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi team, thank you for your response. Yes, I am aware that omission of the activation bar is optional. However, being consistent in the choice as to whether to show/not show the activation bar is important as well. I have attached a relevant screenshot from the CS2113 website for your reference.

image.png

This diagram fulfills the criteria highlighted in the screenshot above, whereby:

Hence, following the guidelines provided by the CS2113 website, this should be considered a bug. I hope this helps you to understand why I feel that the activation bar should not be omitted here. Thanks!