Details in the diagram too small

[Kobot7]

Sequence diagram under Battling Component section is very long and appears to be quite small

[nus-se-bot]

Team's Response

A lot of methods was not included and reduced as it was deemed to be not as important to be shown. The size of the sequence diagram is deemed to be of an adequate size for a developer to be able to follow

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [x] I disagree

Reason for disagreement: Hi team, thank you for your response. I would like to provide explanations in return to the points that you have brought up.

"A lot of methods was not included and reduced as it was deemed to be not as important to be shown."

• This does not directly address why the diagram should not be considered complicated and long. If someone asks "why is this bag so heavy?", responding with "we had to remove 2 kg worth of items" doesn't make sense.
• I tried to interpret what the team was trying to say, and if my guess is correct, I believe that the team is attempting to say that you have already reduced the amount of details to the best that you can.
• This is obviously false when one takes a look at the sequence diagram (I have attached a screenshot below for convenience). Unnecessary details such as the unused :UI, :Parser and :FileReader classes could have been removed from the diagram.

"The size of the sequence diagram is deemed to be of an adequate size for a developer to be able to follow"

• First, let us define what is an adequate size for a sequence diagram. I have attached an image of a borderline "too complicated" sequence diagram (taken from the CS2113 website) below for your reference.
• Comparing the diagrams, we can see how the team's "Battling Component" sequence diagram is even more complicated than the example that is given.
• To be very exact in how it is "more complicated", lets try to gauge how much details is show.
  • "Battling Component" sequence diagram: 12 classes. ~20 calls with 4 logic boxes.
  • CS2113T example sequence diagram: 5 classes. ~10 calls with 2 logic boxes.

I hope that this helps you to understand my perspective as to why the diagram is considered overly complicated and should hence be considered a bug. Nevertheless, thanks for taking time to respond to my report!

Regards, One of the team's PE testers

---