Open Kobzol opened 3 months ago
cargo-pgo currently sets PGO rustflags through target.*.rustflags from Rust 1.63+ (since https://github.com/Kobzol/cargo-pgo/pull/57, see https://github.com/Kobzol/cargo-pgo/issues/56 for the reasoning). This means that if you have e.g. build.rustflags in your Cargo config file, it will be overridden by the flags set by cargo-pgo.
cargo-pgo
target.*.rustflags
build.rustflags
It might be useful to some users to give them the option to decide whether they want to use the target or the build rustflags. The latter might be useful if the user already has some build.rustflags value set and they do not want to override them.
This was suggested here.
cargo-pgocurrently sets PGO rustflags throughtarget.*.rustflagsfrom Rust 1.63+ (since https://github.com/Kobzol/cargo-pgo/pull/57, see https://github.com/Kobzol/cargo-pgo/issues/56 for the reasoning). This means that if you have e.g.build.rustflagsin your Cargo config file, it will be overridden by the flags set bycargo-pgo.It might be useful to some users to give them the option to decide whether they want to use the target or the build rustflags. The latter might be useful if the user already has some
build.rustflagsvalue set and they do not want to override them.This was suggested here.