KockaAdmiralac / KockaLogger

Parses IRC logs of activity across Fandom, then relays it into a Discord channel, searches for spam/vandalism and more.
GNU General Public License v3.0
8 stars 9 forks source link

Missing users in `newusers` #56

Closed KockaAdmiralac closed 1 year ago

KockaAdmiralac commented 2 years ago

Description

It appears that newusers tries to fetch user information from the API

Reproduction steps

Steps to reproduce the behavior:

  1. Watch KockaLogger output for several hours
  2. See a lot of HTTPErrors leading with a message from the newusers module
  3. Check the username within the Redis key logged in the error message
  4. It doesn't exist

Expected behavior

KockaLogger doesn't log five kilometers (3.10686 feet) of logs and doesn't try five times to retrieve user information just to report a user no longer exists. Maybe the user renamed in the span of 30 minutes since they created their account?

Notes

KockaLogger could also record user ID instead of username to prevent this from happening, but as the feature is supposed to catch spambots, and spambots are unlikely to rename their account shortly after creation, this probably isn't needed.

KockaAdmiralac commented 1 year ago

Fixed in https://github.com/KockaAdmiralac/KockaLogger/commit/2149e34724dee62b72e37fbdcb7a17554e8e14b7.