search

KocproZ / jenkins-discord

A post-build plugin that sends the build status to a Discord channel.
MIT License
39 stars 36 forks source link

Too big embeds payload #4

Closed Dahlgren closed 7 years ago

Dahlgren commented 7 years ago

If the builds has quite a few artifacts the webhook request silently fails without any output in neither the build log or the Jenkins logger. One possible solution is to add a link to the artifacts page instead. That's our temporary solution at least :)

Discord returns a 400 BAD REQUEST and the following payload:

{
    "embeds": [
        "0"
    ]
}

Thanks for a great plugin!

jupjohn commented 7 years ago

Thanks for letting me know and apologies for my absence.

I assume it's sending a payload more than 2000 characters so I'll do a check after artifacts and changes to make sure they don't push the limit. If only Discord sent back a proper error response.

EDIT: Max size is 2048 characters for an embed description.

jupjohn commented 7 years ago

Supposedly fixed in the most recent commit.