search

KocproZ / jenkins-discord

A post-build plugin that sends the build status to a Discord channel.
MIT License
39 stars 36 forks source link

Feature Request: For Multi-configuration projects, show build name AND configuration name #41

Closed melt7777 closed 5 years ago

melt7777 commented 5 years ago

My name is melt7777 and I work with the PiMP OS Dev Team. We have filed this issue based on our testing. Thank you very much for your work toward our mutual goal of making easy and effective tools for jenkins. We are bringing this feature request to light because we believe it will be a good improvement to this software and we were unable to figure out how to do it, so we need your help.

We use many "Multi-Configuration Projects" in Jenkins to build a project across several production versions of our product based on labels of the nodes. For these projects, when jenkins-discord posts the notification to our discord channel, it shows up as the label but without the build name. We would like to add multi-configuration handling support or options such that, we can see the build name and the label. Thankfully, you did implement some new features in 1.4.1 that we can try to use to alleviate this (Advanced -> Title) However, we believe that this should not be an override but a default behavior. Also, this forces us to choose between build name and the label of the configuration.

Example screenshot, showing first, the label version, and then the specified titles:

image

Thank you very much for considering this improvement in your development and again great work on a very useful plugin!

~ melt7777 getpimp.org | miner.farm

KocproZ commented 5 years ago

Ok, i made this: image If this is what you had in mind you can download it here.

melt7777 commented 5 years ago

I did install that build but it is not providing the output like your example: I tried with and without titles and with various configurations. Updated Jenkins to latest, Double checked uninstalled and reinstalled your build and turned the version display back on. It is still showing the MC as before. Please advise?

image

image

KocproZ commented 5 years ago

Sorry for that, I misplaced some code. This new build should work as expected.

melt7777 commented 5 years ago

Excellent work! With or without a title specified, and with or without the version, it works as expected and as requested! Thank you so much for this. Please make it part of the main stream build, as it is a great improvement to an awesome plugin. Have a great evening!

image