Fix segmentation fault in Kinc hxcpp backend when cutting/copying big strings

Kode / Kha

Ultra-portable, high performance, open source multimedia framework.

http://kha.tech

zlib License

1.49k stars 174 forks source link

Fix segmentation fault in Kinc hxcpp backend when cutting/copying big strings #1303

Closed Sanva closed 3 years ago

Sanva commented 3 years ago

This is the companion of https://github.com/Kode/Kinc/pull/603 — I've only tested the bug and the solution in Linux, but judging by the code this side of the problem should be affecting other targets, I suppose all that use Kinc hxcpp backend.

Sanva commented 3 years ago

@RobDangerous just a doubt I have while investigating a possible reimplementation for https://github.com/Kode/Kinc/pull/603 — would using malloc be acceptable in Kha, taking into account that is is intended to be used with Haxe, a GC language?

RobDangerous commented 3 years ago

Yes, in Kha it's ok.

Sanva commented 3 years ago

I'm closing this for now, since it looks like I'm accidentally making changes to this pull-request by updating my fork of Kha... sorry for the noise.