search

Kode / Kha

Ultra-portable, high performance, open source multimedia framework.
http://kha.tech
zlib License
1.49k stars 174 forks source link

Report HTML5 file drop events #1304

Closed tong closed 3 years ago

tong commented 3 years ago

Not sure why this is hidden behind the kha_debug_html5.

RobDangerous commented 3 years ago

git blame to the rescue - hey @zshoals, what do you think of this?

tong commented 3 years ago

Well, there seems to be no way to actually read the contents of the dropped file, maybe that's why. Also wondering how this could fit into current api.

zshoals commented 3 years ago

git blame to the rescue - hey @zshoals, what do you think of this?

git blame lies. This was the first PR I made to Kha and you can see that that conditional compilation block is still in there: https://github.com/Kode/Kha/pull/1227

RobDangerous commented 3 years ago

Ah, indeed. It was @sh-dave! Hey Dave, can we remove that #if?

sh-dave commented 3 years ago

I think i never tested this in a browser, so sure, go ahead and remove the ifdef if it's working properly.

RobDangerous commented 3 years ago

Let's go and hope for the best.