search

Kode / Kha

Ultra-portable, high performance, open source multimedia framework.
http://kha.tech
zlib License
1.49k stars 174 forks source link

Quick solution for an Iron error. #1314

Closed Lykdraft closed 3 years ago

Lykdraft commented 3 years ago

A quick solution to this problem: https://github.com/armory3d/iron/issues/119

Pretty sure this could be solved in a better way? Best, tL.

sh-dave commented 3 years ago

Why don't you just use armory3d's Kha fork, that already includes this?

Lykdraft commented 3 years ago

I do. But git recursive remote. So it looks like that the Armory/Kha fork is behind the actual Kha fork ? But this PR is not needed anymore anyway I think.

Hi, thanks for report.

It looks like lockInt16() is no longer available in the kha/html5 backend: https://github.com/Kode/Kha/blob/master/Backends/HTML5/kha/graphics4/VertexBuffer.hx

But it's still available in the other kha backends: https://github.com/Kode/Kha/blob/master/Backends/Kinc-hxcpp/kha/graphics4/VertexBuffer.hx https://github.com/Kode/Kha/blob/master/Backends/Krom/kha/graphics4/VertexBuffer.hx

Here are related Kha commits I found: Kode/Kha@5c0bf12 Kode/Kha@2e456d4

So the lockInt16() is being unified with lock(), but looks like it's not yet finished in the latest Kha.

(As a temporary workaround armsdk/Kha will work in the meantime.)

sh-dave commented 3 years ago

Well it's 12 commit ahead and 155 commits behind this repository. So i guess it's probably safer to use Lubos's fork as it might contain other changes necessary for iron/armory to work properly, as his Kha fork also seems to use forked submodules.

Lykdraft commented 3 years ago

Aeh, the quote I posted was from Lubos himself, sooo.. I dunno... lol...