Kode / Kha

Ultra-portable, high performance, open source multimedia framework.
http://kha.tech
zlib License
1.48k stars 174 forks source link

add ssl support for hl/c builds #1377

Closed sh-dave closed 2 years ago

sh-dave commented 2 years ago
MoritzBrueckner commented 2 years ago

Hi, I get some linker errors on Windows 10 and VS2019 after this PR:

1>ssl.obj : error LNK2001: Nicht aufgelöstes externes Symbol "__imp_CertOpenSystemStoreW".
1>ssl.obj : error LNK2001: Nicht aufgelöstes externes Symbol "__imp_CertEnumCertificatesInStore".
1>ssl.obj : error LNK2001: Nicht aufgelöstes externes Symbol "__imp_CertCloseStore".

"Nicht aufgelöstes externes Symbol" = "Unresolved external symbol"

sh-dave commented 2 years ago

Looks like we might have to link against Crypt32.lib on windows for that https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-certopensystemstorew. Can you try that please?

MoritzBrueckner commented 2 years ago

Yes, that seems to work :)

sh-dave commented 2 years ago

Cool thanks. Can you open a PR, i don't have access to a windows PC with all the necessary setup to test at the moment?

MoritzBrueckner commented 2 years ago

Yes, do you think it belongs in the kincfile (like this, would be Kha only) or hardcoded directly in Kincmake (here, but would also be included for hxcpp)?

sh-dave commented 2 years ago

Hm, i think I'd add it to the kincfile, but let's summon @RobDangerous

RobDangerous commented 2 years ago

It belongs in the kincfile.