search

Kode / Kha

Ultra-portable, high performance, open source multimedia framework.
http://kha.tech
zlib License
1.48k stars 171 forks source link

Implement gamepad vendor and id attributes in Krom and HL backends #1443

Open MoritzBrueckner opened 1 year ago

MoritzBrueckner commented 1 year ago

gamepad.vendor and gamepad.id currently always return unknown on Krom and empty strings on Hashlink, even though the functionality seems to be implemented in Kinc, at least on Windows and Linux.

Some more context and potentially a Kinc issue (still need to investigate more): https://forums.armory3d.org/t/problem-with-gamepad-sticks-logic-nodes/5087

RobDangerous commented 1 year ago

Hey @Onek8, feel free to post comments with code or better yet send pull requests. But I'll delete zips posted without comment without looking into them.

Onek8 commented 1 year ago

Sorry, I was just sharing the patch that works for linux tested with xbox generic controller, ps4 and ps5. Basically just added the extra axis when triggers + dpad come in as axis and not buttons to trigger the actual button index. It didnt seem like a real fix so I figured it would be best to archive it until it was further investigated. Thank you for explaining the deletion, no zips :)

RobDangerous commented 1 year ago

That's appreciated but please use uncompressed text. You can simply do a git diff and upload that for example - that way everyone can directly see what they get.

MoritzBrueckner commented 8 months ago

Linking to https://github.com/Kode/Kha/pull/1473, the HL part is implemented now.