search

Kode / Krom

Other
97 stars 23 forks source link

Improve krom_log #86

Closed luboslenco closed 6 years ago

RobDangerous commented 6 years ago

Uh oh, that's using a Windows-only API: https://github.com/Microsoft/ChakraCore/wiki/JsStringToPointer (you can still tell easily that the whole thing was Windows-only not too long ago).

luboslenco commented 6 years ago

Argh, will fix tomorrow. I guess the simplest solution is to do string.substr(0, 512) in Kha when calling Krom. Otherwise JsCopyString will abort the process if buffer is too small.

RobDangerous commented 6 years ago

Let's do that then.

luboslenco commented 6 years ago

Should be better now.