search

Kode / khamake

Kha's build tool.
http://kha.tech
15 stars 43 forks source link

Source code not recompiled on change #155

Closed carlito767 closed 6 years ago

carlito767 commented 6 years ago

Hi,

I recently updated my project to the latest Kha and the source code is not recompiled on change anymore. Here is the batch file used to build the project:

pushd .. start /B node Kha/make html5 --watch start /B node Kha/make --server popd

It seems related to this revision.

RobDangerous commented 6 years ago

chokidar is the dependency responsible for watching for file changes, see if updating that helps.

carlito767 commented 6 years ago

I updated all modules (including chokidar 2.0.4) but same issue. Could you confirm you have the problem (to be sure it's not only on my side)?

RblSb commented 6 years ago

The last working commit for you is this?

carlito767 commented 6 years ago

Yes.

Le sam. 18 août 2018 à 18:56, RblSb notifications@github.com a écrit :

The last working commit for you is this https://github.com/Kode/khamake/commit/668fdaaec20592eee3fd844de9003d79a4dec00e ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Kode/khamake/issues/155#issuecomment-414071702, or mute the thread https://github.com/notifications/unsubscribe-auth/AabkGLoqDcUmjn5vjVKROoGry6Vtwikjks5uSEdRgaJpZM4WCk1H .

RblSb commented 6 years ago

@carlito767 You can try install old chokidar version and set it in package.json for latest khamake, perhaps it will give some results.

carlito767 commented 6 years ago

When I come back to chokidar@1.7.0, it works. But it fails with the next release (chokidar@2.0.0).

RobDangerous commented 6 years ago

I can not reproduce your problems but this is a good data point. I'll look into removing chokidar, it also has problems with specific chars in paths which haven't been fixed in years.

RblSb commented 6 years ago

@carlito767 You might want to check 15 chockidar commits to identify the problem (this is 4 tests if you start from the middle of the groups) https://github.com/paulmillr/chokidar/compare/1.7.0...2.0.0 If you find, report the issue in their repo.

RblSb commented 6 years ago

Also, try this khamake branch https://github.com/RblSb/khamake/tree/chokidar_fix

RblSb commented 6 years ago

I found that chokidar 2.0 supports only posix slashes, so this actually should help.

carlito767 commented 6 years ago

I tried your fix and it works! Thanks!