Kode / khamake

Kha's build tool.
http://kha.tech
15 stars 45 forks source link

Fix addLibrary infinite loop when haxelib has circular dependencies #229

Closed undefinist closed 4 years ago

undefinist commented 4 years ago

Some haxelibs have circular dependencies, e.g. munit -> mcover -> munit, causing addLibrary to loop forever.

RobDangerous commented 4 years ago

But that's the wrong file, please change the typescript file instead.

undefinist commented 4 years ago

Sorry, I'm pretty dumb

RobDangerous commented 4 years ago

Don't worry, that's not the important part. Would do the nitpicky things myself but I want to get the commit log right so people are properly credited for what they did. Thanks for the fix!