search

Kode / khamake

Kha's build tool.
http://kha.tech
15 stars 45 forks source link

Still retrieve git-version if using gitdir [no more ¯\_(ツ)_/¯] #250

Closed XANOZOID closed 3 years ago

XANOZOID commented 3 years ago

Support an alternative git structure that uses gitdir: instead of a directory with git information.

This fixes an issue, for me at least, where Khamake was only printing out ¯\_(ツ)_/¯ for the version instead of the actual git version. I'm not sure if anything about git changed recently, but my project doesn't utilize git folders it just contains information in the .git file of where the relative git directory is.

RobDangerous commented 3 years ago

There's a small style-issue to fix, would you do the honors?

XANOZOID commented 3 years ago

There's a small style-issue to fix, would you do the honors?

Ahh, okay - taken care of! How can I check that on my side before submitting a pr, next time, if I may ask?

RobDangerous commented 3 years ago

Next time the GitHub-check will run automatically. To check it locally I use a tsline extension for vscode but you can also just run tsline manually.

RobDangerous commented 3 years ago

*tslint