search

KodersLab / react-native-for-web

A set of classes and react components to make work your react-native app in a browser. (with some limitations obviously)
MIT License
255 stars 17 forks source link

React.Platform api ? #7

Closed chandu0101 closed 9 years ago

chandu0101 commented 9 years ago

does it make sense to web ?

mattiamanzati commented 9 years ago

It makes sense for sure, I am debating about the value of Platform.OS, maybe "browser" should be enough?

chandu0101 commented 9 years ago

maybe "browser" should be enough?

:+1:

chandu0101 commented 9 years ago

@mattiamanzati hey my library https://github.com/chandu0101/sri web module depends on react-native-for-web , currently i am using ugly hack(if(!React.Platform)) to determine if its browser , i badly need this .

I just opened a PR #9 please review it , btw few spoon feeding steps on how to run examples / update docs / publish local will be good ,especially for people like me ( new to this javascript land).

mattiamanzati commented 9 years ago

Yeah I'll be working on that For dure! Unfortunately until the end of the month I am a Little busy with the office, thanks For Your PR!