Kodi-vStream / venom-xbmc-addons

Addon de Streaming français pour Xbmc
GNU General Public License v3.0
489 stars 275 forks source link

[Feature Request] [UpToBox] Support external subtitles within same directory #4074

Open TheRadziu opened 1 year ago

TheRadziu commented 1 year ago

I just found your addon and so far I am pleased with it. Although there is one thing it lacks with comparison to Google Drive Addon; Support for external subtitles (txt, ass, srt, ssa etc) within same directory for example: FolderName -video.mkv -video.ass

Video plays just fine but you cant select video.ass subtitles, only embeded subs.

Hope it aint much to ask, should be a quick, yet very usable feature to add :)

My current setup is: latest version of the addon from repository + Direct Link Mode

sizanic commented 1 year ago

Our addon is for streaming only, so no subtitles are expected, as there is no folder for a streaming link.

In this case, it is possible to use a subtitle addon that downloads subtitles on demand.

image

TheRadziu commented 1 year ago

Subtitle files are already 'seen' by addon when it parses directory contents. Its just matter of adding 'when video is played, if there is the same filename with subtitle extension, download it to memory and use as forced subtitle track' Screenshot_20230710-122843

Besides, using subtitle addon is out of the question since most of my subtitles are either downloaded from fansub site that has no addon or synced manually by me.

sizanic commented 1 year ago

I'll take a look... 👍🏻