KodlabPenn / kodlab_mjbots_sdk

Repo for kodlab SDK for use with mjbots ecosystem
Other
8 stars 7 forks source link

Base classes need virtual destructors #49

Closed ethanmusser closed 1 year ago

ethanmusser commented 2 years ago

Discussions in #39 pointed out that some of our inherited classes may not have a virtual destructor. As discussed here (in the Virtual Destructors section), virtual destructors are necessary in base classes to permit appropriate destruction of derived classes through pointers to their base.

TODO:

ShaneRozenLevy commented 2 years ago

I think the biggest improvement here is that it will probably stop the code from seg faulting on exit.

ethanmusser commented 2 years ago

Actually I think we unintentionally fixed that at some point along the way, the code doesn't seg fault on exit anymore. But a good preventative measure nonetheless.

jdcaporale commented 1 year ago

89 Did this.