KodrAus / decstr

IEEE 754 decimal floating point bitstrings
Apache License 2.0
6 stars 1 forks source link

fix warnings and add missing derives #12

Closed joseluis closed 1 year ago

joseluis commented 1 year ago

Please don't hesitate to ask for any details, or request things be done differently.

I derived the missing Clone and Copy for Bitstring64 and Bitstring128.

And the reason for the the globally allowed clippy::derivable_impls is because it complained about a couple of manually Default impls that could be derived, but I think it's more clear in the context of multiple manualy derives with non-obvious fields. And in the case of clippy::comparison_chain it complained about an if chain that couldn't be transformed into match because a match can't use dynamic values, so it doesn't seem very smart and I disabled it.