search

Kodular / Documentation

Kodular Documentation
https://docs.kodular.io
Other
55 stars 85 forks source link

Update barcode-scanner.md #33

Closed AryaDeepanshu closed 5 years ago

AryaDeepanshu commented 5 years ago

Added barcode scanner docs

Types of changes:

Checklist:

shreyashsaitwal commented 5 years ago

Just a quick note, docs are written in markdown, not HTML.

AryaDeepanshu commented 5 years ago

Just a quick note, docs are written in markdown, not HTML.

Is it not allowed or its generalization?? Does it look awkward?

shreyashsaitwal commented 5 years ago

Afaik, it's not allowed.

AryaDeepanshu commented 5 years ago

Afaik, it's not allowed.

Updated in Markdown

shreyashsaitwal commented 5 years ago

Seems like you aren't following the standard format in which Kodular docs are written. Please take a look at other merged PRs to get familiar with the format.

AryaDeepanshu commented 5 years ago

Seems like you aren't following the standard format in which Kodular docs are written. Please take a look at other merged PRs to get familiar with the format.

can you please refer me to the defect?

shreyashsaitwal commented 5 years ago

Seems like you aren't following the standard format in which Kodular docs are written. Please take a look at other merged PRs to get familiar with the format.

can you please refer me to the defect?

Why don't you just take a look at older PRs? 🙂

barreeeiroo commented 5 years ago

@AryaDeepanshu This PR does not follow the standards and formats that we use in Documentation. Please, check the already merged PRs and/or the already written components to see how to properly documentate Kodular Creator. Feel free to re-open this PR whenever you consider, thanks!

barreeeiroo commented 5 years ago

The reason of closing is that the PR is not as much complete to be reviewed so far. We require all components to follow a structure, as Kodular Creator links to each block, so that when you click "Learn more" you get redirected to such block. In your PR this will not happen, as plain MD will not fit in rendered MKDocs. Also, we have to keep all components docs uniform for a better understanding.