Koed00 / django-q

A multiprocessing distributed task queue for Django
https://django-q.readthedocs.org
MIT License
1.8k stars 274 forks source link

Can someone relinquish django-q and allow the django-q2 community to fold in? #735

Open eddyojb88 opened 7 months ago

eddyojb88 commented 7 months ago

I am a prospective user of this great sounding package but it horrifies me that this has:

Can someone relinquish and allow updating of this please?

Koed00 commented 7 months ago

How do you propose we do this? I'll gladly add a maintainer or something similar. As far as I can tell I have not been contacted to do something with the q2 community. If you can come up with a good plan, I'll help.

Tobi-De commented 7 months ago

Hi @Koed00, hope you're doing well. I think the easiest solution would be to add a notice to the readme, redirecting anyone looking for an active version of the project to q2. If you ever decide to come back to it, I'm sure you can work something out with the q2 maintainer. At the end of the day, this is open source; you don't owe anyone anything, and I think you've done enough already. Take all the rest you want, but for all the lost souls who open issues on this repo, they'll know where to find satisfaction (on the q2 repo).

eddyojb88 commented 7 months ago

I am only a very recent observer looking at decent options like Django-Q - it looks like what I am after but I don't want to get stuck down the line and I don't know what I don't know at this stage.

The readme solution sounds reasonable as a starting point - incoming traffic until then has likely seen the last commit date and run for celery.

GDay commented 7 months ago

I am the maintainer of django-q2.

The README change sounds good. Might want to put this repo in public archive than to avoid further issues/pull requests.

I am also open to merge django-q2 into django-q and then keep both packages up to date on PyPI and perhaps add a deprecation message to django-q2. There are still a lot more downloads for django-q than django-q2. The people maintaining those projects are likely not aware that there is a newer version.

Downside of this would be that nearly all PRs would be broken, since I have changed the structure of django-q (moved all processes from cluster.py to separate files).

jyoost commented 7 months ago

This message is from Johns widow My husband went to Heaven on October 19 and is not suffering Thank you Have a safe Blessed Holiday

On Mon, Nov 27, 2023, 1:12 PM Stan Triepels @.***> wrote:

I am the maintainer of django-q2.

The README change sounds good. Might want to put this repo in public archive than to avoid further issues/pull requests.

I am also open to merge django-q2 into django-q and then keep both packages up to date on PyPI and perhaps add a deprecation message to django-q2. There are still a lot more downloads for django-q than django-q2. The people maintaining those projects are likely not aware that there is a newer version.

Downside of this would be that nearly all PRs would be broken, since I have changed the structure of django-q (moved all processes from cluster.py to separate files).

— Reply to this email directly, view it on GitHub https://github.com/Koed00/django-q/issues/735#issuecomment-1828619798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKU5P6NUWHUHOX4TLBYSKJDYGT63BAVCNFSM6AAAAAA74FFGLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGYYTSNZZHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Koed00 commented 7 months ago

Stan, I've added you as a collaborator. That should give you enough access to do what you want. I'll help where I can - I just haven't actively used Django in any projects for some years now so my focus shifted away. The most important thing is that the community can keep using it and it doesn't stay in unmaintained hell.

GDay commented 7 months ago

@Koed00 Thanks a lot. Really appreciate that.

I think the best way forward would be to shut the django-q2 repo down, merge it here and then continue, as I suggested here:

I am also open to merge django-q2 into django-q and then keep both packages up to date on PyPI and perhaps add a deprecation message to django-q2. There are still a lot more downloads for django-q than django-q2. The people maintaining those projects are likely not aware that there is a newer version.

However, collaborator access doesn't give me enough to do that. What I would need to be able to do:

  1. Access to secrets, to add my PyPI token for updating the django-q2.
  2. Automate the django-q package release (just like the django-q2 release)

For 1, I could also push updates manually, or run the release workflow on my own repo. For 2, could you add me to the PyPI package as a maintainer/owner (same username: gday)? That way I can use my token to push new updates for the original django-q package.

I think the best way to move forward is to move this package from a personal account to an organization, since we would have more fine-grained permissions. That could also allow me to add other maintainers later, in case I don't have time to maintain it anymore (and not repeat the "unmaintained hell" again).

If you don't want to do that, then that's fine. I can also just replace the README file with a link to the django-q2 repo and continue there.

Either option is fine by me.

Koed00 commented 7 months ago

I don't think I can give you access to the secrets. But you can add repos to PyPi that can automatically trigger a release.

I've added you as a maintainer on PyPi. And in case we want to use that at a later date; I've secured https://github.com/django-q and invited you there as well.

mkokotovich commented 5 months ago

Hello! I'm happy to see conversation on here about a future. Has there been any progress since November?

GDay commented 5 months ago

I have gotten extremely busy with work since then and I am trying to catch up. I will be back at this in a week or two (hopefully sooner).

targetblank commented 4 months ago

Hi @GDay, I've been really happy to see you engaged in djangoq maintenance. Do you have any update regarding the process of merging your django-q2 into this repository, or if it makes more sense to switch to your fork?

GDay commented 4 months ago

@targetblank I have made a PR into this repo. I need to update the docs to make them both reference django-q instead of django-q2 (PR is ready for that) and then also update the deploy workflow so both will get the update when I commit/merge something. Then it's ready. django-q and django-q2 will be the same very soon. You can use the django-q2 and later switch back or you can stay on it. Django-q and django-q2 will stay in sync, even after merge.

eddyojb88 commented 4 months ago

This is amazing @GDay, looking to try out django q2 in the coming days

targetblank commented 4 months ago

Really good news, @GDay. Thanks you for your efforts on the project!

OmarAboulMakarem commented 3 months ago

Great Work, looking forward for the merge