KoenZomers / RingApi

Api in .NET 6 to communicate with the Ring Doorbell services
38 stars 18 forks source link

Missing property for authorized_doorbots #6

Closed insane4sure closed 4 years ago

insane4sure commented 4 years ago

My doorbots come in as "authorized_doorbots" instead of "doorbots". Solved with an addition to KoenZomers.Ring.Api.Entities.Devices

namespace KoenZomers.Ring.Api.Entities
{
    /// <summary>
    /// Contains a collection of Ring devices
    /// </summary>
    public class Devices
    {
        /// <summary>
        /// All Ring doorbots
        /// </summary>
        [JsonProperty(PropertyName = "doorbots")]
        public List<Doorbot> Doorbots { get; set; }

        /// <summary>
        /// All Authorized Ring doorbots
        /// </summary>
        [JsonProperty(PropertyName = "authorized_doorbots")]
        public List<Doorbot> AuthorizedDoorbots { get; set; }

        /// <summary>
        /// All Ring chimes
        /// </summary>
        [JsonProperty(PropertyName = "chimes")]
        public List<Chime> Chimes { get; set; }

        /// <summary>
        /// All Ring stickup cameras
        /// </summary>
        [JsonProperty(PropertyName = "stickup_cams")]
        public List<StickupCam> StickupCams { get; set; }
    }
}
KoenZomers commented 4 years ago

Implented in version 0.4.0.2. Feel free to next time submit suggestions like this in a pull request instead to make it easier for me to merge it. Thanks!

insane4sure commented 4 years ago

Will do. Thanks!

/ben


From: Koen Zomers notifications@github.com Sent: Monday, December 23, 2019 6:17:48 PM To: KoenZomers/RingApi RingApi@noreply.github.com Cc: Benjamin Saberin ben@saberin.com; Author author@noreply.github.com Subject: Re: [KoenZomers/RingApi] Missing property for authorized_doorbots (#6)

[EXTERNAL EMAIL]

Implented in version 0.4.0.2https://www.nuget.org/packages/KoenZomers.Ring.Api/0.4.0.2. Feel free to next time submit suggestions like this in a pull request instead to make it easier for me to merge it. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/KoenZomers/RingApi/issues/6?email_source=notifications&email_token=ABJE4QSKQQUHEAQIOQSQ4NDQ2FBJZA5CNFSM4JXU7X7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHSDKQA#issuecomment-568603968, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJE4QQSAPVUTP6REZO36BLQ2FBJZANCNFSM4JXU7X7A.