Koeng101 / dnadesign

A Go package for designing DNA.
Other
23 stars 0 forks source link

murmur3 to crc32 #29

Closed Koeng101 closed 10 months ago

Koeng101 commented 10 months ago

We should switch from murmur3 to crc32 for hashing in mash as a default. crc32 is used in the standard library, which is nice, plus it should be good enough https://rigtorp.se/notes/hashing/

Generally, we should be using the (Hash interface)[https://pkg.go.dev/hash#Hash] and allowing users to pick the algorithm, but having crc32 for a basic default seems like a good idea.