Koenkk / zigbee-OTA

A collection of Zigbee OTA files
GNU General Public License v3.0
416 stars 200 forks source link

Add custom firmware from pvvx for Xiaomi LYWSD03MMC #441

Closed kwiateusz closed 8 months ago

kwiateusz commented 9 months ago

Resository the file came from: https://github.com/pvvx/ZigbeeTLc

Koenkk commented 9 months ago

@devbis @krzysztof-kwitt asking because of https://github.com/Koenkk/zigbee-herdsman-converters/pull/7015, can I merge this?

devbis commented 9 months ago

I don't have any objections. Though, this fork in it's current state it will not be supported by converters due to a different structure of clusters and the exactly same model/manufacturer.

kwiateusz commented 9 months ago

If it will not be supported then there is no point in adding, thanks for the information and I need to migrate my devices :)

krzysztof-kwitt commented 9 months ago

@kwiateusz We already are working to support this. It still makes sense for me.

krzysztof-kwitt commented 9 months ago

Latest version of Z2M supports pvvx firmware.

devbis commented 9 months ago

@kwiateusz It will be supported but without changes in pvvx's firmware https://github.com/pvvx/ZigbeeTLc/pull/52 only basic functionality (temperature + humidity) will be available with z2m. Either custom convertor will be required.

pbranly commented 9 months ago

Hi Could you explain the role of those additional settings ? In z2m there are 2 ways to change temperature and humidity calibration. Which one is used ? In addition there are also settings for confort min/max temp and humidity. Same question : what is the role of those new settings Thanks Phil

devbis commented 9 months ago

@pbranly Additional settings affect display values as well, while z2m internal calibration only modifies data in z2m and mqtt. Comfort parameters is a configuration for happy/sad face on the display.

kwiateusz commented 8 months ago

I've pushed a new version which shouldn't interfere with devbis converter

Koenkk commented 8 months ago

@devbis @krzysztof-kwitt can you do a final check?

devbis commented 8 months ago

LGTM

Koenkk commented 8 months ago

Thanks!