search

Koenkk / zigbee-herdsman-converters

Collection of device converters to be used with zigbee-herdsman
MIT License
882 stars 2.93k forks source link

local temperature calibration are buggy after the last release and should accept float again #3488

Closed KartoffelToby closed 2 years ago

KartoffelToby commented 2 years ago

Since the PR #3341 i have problems with my TRV calibration,

If i read the changes correctly the local_temperature_calibration have now a min and max and steps option,

by default min is set to -20 and max to 20 which should be good for most usecases, but my SPZB0001 and SEA801-Zigbee/SEA802-Zigbee are limit to -6 and 6 thats not good, also see that the steps are 1 by default, as the most devices have 2 or more digs the calibration shoud accept float values too. It works well in older versions.

Also have some bugs in rounding if a value outside of -6 6 is set and the device jumps to 4294967287

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days